Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: undici fetch in watch #399

Merged
merged 40 commits into from
Nov 5, 2024
Merged

feat: undici fetch in watch #399

merged 40 commits into from
Nov 5, 2024

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Oct 3, 2024 •
edited
Loading

Description

Change node-fetch for undici fetch and native stream. This is a POC to determine whether we get better results before changing the whole node-fetch library out.

Soak results report 0 watch misses over 6 hours and 45 mins (3 soaks)

Definition of done:

  • Sustains memory in UDS Core
  • Does not miss events in soak test
  • still can run npx pepr dev

image

image

Related Issue

defenseunicorns/pepr#1180

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19
chore: native fetch
dece9ed 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: updates
62df6f5 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: better comments
bc2b80f 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
current testing
6beecd8 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: WIP
37cc70a 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: updates to test and lint
c1c67ec 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 changed the title Undici fetch feat: change switch fetch to undici fetch Oct 3, 2024
@cmwylie19 cmwylie19 changed the title feat: change switch fetch to undici fetch feat: change switch fetch to undici fetch in watch Oct 3, 2024
cmwylie19
cmwylie19 commented Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 commented Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
cmwylie19
cmwylie19 commented Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
fast.sh Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/utils.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
jeff-mccoy
jeff-mccoy reviewed Oct 3, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
@cmwylie19
chore: address pr comments
673014a 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: format
88fb8fb 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19
chore: watch-update
0f76826 
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 requested a review from btlghrants as a code owner November 4, 2024 22:16
@cmwylie19 cmwylie19 changed the title feat: change switch fetch to undici fetch in watch feat: undici fetch in watch Nov 4, 2024
@btlghrants btlghrants mentioned this pull request Nov 5, 2024
Merged
5 tasks
cmwylie19
cmwylie19 commented Nov 5, 2024
View reviewed changes
src/fluent/watch.ts Outdated Show resolved Hide resolved
btlghrants
btlghrants approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmwylie19 cmwylie19 merged commit 4123485 into main Nov 5, 2024
9 checks passed
@cmwylie19 cmwylie19 deleted the undici-fetch branch November 5, 2024 22:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

samayer12 pushed a commit to defenseunicorns/pepr that referenced this pull request Nov 6, 2024
@cmwylie19
chore: updates for undici watch (#1384)
6b6d39f 
## Description

Undici fetch is going to be the default watch mechanism in Pepr
`v0.39.0`. This PR updates the docs, watchConfig, and tests that
references http2 and documents the `PEPR_USE_LEGACY_WATCH` env var.

ON HOLD -
defenseunicorns/kubernetes-fluent-client#399 KFC
needs this merged and released

## Related Issue

Fixes #1383 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy left review comments

@btlghrants btlghrants btlghrants approved these changes

Assignees
No one assigned
Labels
released
Projects
Pepr Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmwylie19 @jeff-mccoy @btlghrants