Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errorHandler - should only schedulereconnect if using http2 #441

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

cmwylie19
Copy link
Contributor

Description

errorHandler - should only scheduleReconnect if using http2

Related Issue

Fixes #440

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 changed the title fix: errorHandler - should only scheduleReconnect if using http2 fix: errorHandler - should only schedulereconnect if using http2 Oct 24, 2024
Signed-off-by: Case Wylie <[email protected]>
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@cmwylie19 cmwylie19 merged commit c4940ca into main Oct 24, 2024
9 checks passed
@cmwylie19 cmwylie19 deleted the 440 branch October 24, 2024 16:54
Copy link

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Stream cleanup should be feature gated in Watch Error Handler
2 participants