Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use undici for fetch function #470

Merged
merged 9 commits into from
Dec 2, 2024
Merged

fix: remove use undici for fetch function #470

merged 9 commits into from
Dec 2, 2024

Conversation

cmwylie19
Copy link
Contributor

@cmwylie19 cmwylie19 commented Nov 18, 2024

Description

Changes the fetch function to use undici fetch. Updates the k8sCfg to return undici RequestInit instead of node-fetch RequestInit.

Note: - Do not merge is present on this PR because we are waiting for December to release this as it is a big change to the surface area of KFC and also affects Pepr. This PR removes the remaining node-fetch from Pepr

Related Issue

Fixes #459

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 marked this pull request as draft November 18, 2024 19:07
@cmwylie19 cmwylie19 added the DON'T MERGE We need to wait to merge this label Nov 18, 2024
src/fetch.test.ts Outdated Show resolved Hide resolved
src/fetch.test.ts Outdated Show resolved Hide resolved
src/fetch.test.ts Outdated Show resolved Hide resolved
src/fetch.ts Show resolved Hide resolved
src/fluent/utils.test.ts Outdated Show resolved Hide resolved
src/fluent/utils.test.ts Outdated Show resolved Hide resolved
src/fluent/utils.ts Outdated Show resolved Hide resolved
src/fluent/utils.ts Outdated Show resolved Hide resolved
@cmwylie19 cmwylie19 marked this pull request as ready for review December 2, 2024 17:07
@cmwylie19 cmwylie19 requested a review from a team as a code owner December 2, 2024 17:07
@cmwylie19 cmwylie19 removed the DON'T MERGE We need to wait to merge this label Dec 2, 2024
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'kay!

@cmwylie19 cmwylie19 enabled auto-merge December 2, 2024 17:15
@cmwylie19 cmwylie19 disabled auto-merge December 2, 2024 17:15
@cmwylie19 cmwylie19 merged commit 015e9e5 into main Dec 2, 2024
10 checks passed
@cmwylie19 cmwylie19 deleted the 459 branch December 2, 2024 17:15
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 3.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove node-fetch as the library for the relist
3 participants