Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: squash security alert by setting string #475

Merged
merged 3 commits into from
Nov 20, 2024
Merged

chore: squash security alert by setting string #475

merged 3 commits into from
Nov 20, 2024

Conversation

cmwylie19
Copy link
Contributor

Description

Averts this security warning for insecure randomness https://github.com/defenseunicorns/kubernetes-fluent-client/security/code-scanning/14

Related Issue

Fixes #474

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 changed the title chore: squah security alert by setting string chore: squash security alert by setting string Nov 19, 2024
Copy link
Contributor

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying that we have to do this -- sometimes you just don't care that randomness is "secure". Blerg.

Change looks fine though.

@cmwylie19 cmwylie19 merged commit 61ac7cf into main Nov 20, 2024
9 checks passed
@cmwylie19 cmwylie19 deleted the sec_patches branch November 20, 2024 14:57
Copy link

🎉 This PR is included in version 3.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Insecure randomness
2 participants