Skip to content

Commit

Permalink
fix(ci): semgrep cli breaking change (ethereum-optimism#11985)
Browse files Browse the repository at this point in the history
Semgrep CLI tool recently removed the --time option which caused
CI to suddenly break.
  • Loading branch information
smartcontracts authored Sep 18, 2024
1 parent c18ec26 commit 606e023
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1397,11 +1397,10 @@ jobs:
echo 'export SEMGREP_REPO_NAME=$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME' >> $BASH_ENV
- run:
name: "Semgrep scan"
# --time shows which rules take the most time
# --timeout (in seconds) limits the time per rule and file.
# SEMGREP_TIMEOUT is the same, but docs have conflicting defaults (5s in CLI flag, 1800 in some places)
# https://semgrep.dev/docs/troubleshooting/semgrep-app#if-the-job-is-aborted-due-to-taking-too-long
command: semgrep ci --time --timeout=100
command: semgrep ci --timeout=100
# If semgrep hangs, stop the scan after 20m, to prevent a useless 5h job
no_output_timeout: 20m
- notify-failures-on-develop
Expand Down

0 comments on commit 606e023

Please sign in to comment.