Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove immutables from superchain erc20 beacon #67

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: remove immutables from superchain erc20 beacon #67

merged 2 commits into from
Sep 30, 2024

Conversation

agusduha
Copy link
Member

Closes OPT-217

@agusduha agusduha self-assigned this Sep 26, 2024
@linear Linear
Copy link

linear bot commented Sep 26, 2024

OPT-217 Check OptimismSuperchainERC20Beacon Proxy Impl

0xDiscotech
0xDiscotech reviewed Sep 26, 2024
View reviewed changes
Copy link

@0xDiscotech 0xDiscotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a small test for it so the implementation function is covered

@agusduha agusduha merged commit 40e2069 into sc-fix/remove-immutables-from-superchain-erc20-beacon Sep 30, 2024
3 checks passed
@agusduha agusduha deleted the fix/remove-immutables-from-superchain-erc20-beacon branch September 30, 2024 17:28
agusduha added a commit that referenced this pull request Oct 22, 2024
@agusduha
fix: remove immutables from superchain erc20 beacon (ethereum-optimis…
3af1faf 
…m#12207)

* fix: remove immutables from superchain erc20 beacon (#67)

* fix: remove immutables from superchain erc20 beacon

* test: add superchain erc20 beacon tests

* fix: superchain erc20 beacon interface (#99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDiscotech 0xDiscotech 0xDiscotech approved these changes

Assignees

@agusduha agusduha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agusduha @0xDiscotech