feat: code review feedback

defi-wonderland · Nov 21, 2023 · 1edb07b · 1edb07b
1 parent 9c00fc3
commit 1edb07b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -227,6 +227,9 @@ contract Oracle is IOracle {
     DisputeStatus _status
   ) external {
     bytes32 _disputeId = _getId(_dispute);
+    bytes32 _requestId = _getId(_request);
+
+    if (_response.requestId != _requestId || createdAt[_requestId] == 0) revert Oracle_InvalidRequestBody();
 
     if (disputeOf[_getId(_response)] != _disputeId) {
       revert Oracle_InvalidDisputeId(_disputeId);

diff --git a/solidity/test/unit/Oracle.t.sol b/solidity/test/unit/Oracle.t.sol
@@ -49,6 +49,10 @@ contract MockOracle is Oracle {
     nonceToRequestId[_nonce] = _requestId;
   }
 
+  function mock_setCreatedAt(bytes32 _requestId, uint128 _createdAt) external {
+    createdAt[_requestId] = _createdAt;
+  }
+
   function mock_setTotalRequestCount(uint256 _totalRequestCount) external {
     totalRequestCount = _totalRequestCount;
   }
@@ -440,6 +444,7 @@ contract Unit_UpdateDisputeStatus is BaseTest {
    */
   function test_updateDisputeStatus() public {
     bytes32 _requestId = _getId(mockRequest);
+    oracle.mock_setCreatedAt(_getId(mockRequest), uint128(block.number));
 
     // Try every initial status
     for (uint256 _previousStatus; _previousStatus < uint256(type(IOracle.DisputeStatus).max); _previousStatus++) {
@@ -482,6 +487,7 @@ contract Unit_UpdateDisputeStatus is BaseTest {
 
     // Mock the dispute
     oracle.mock_setDisputeOf(_getId(mockResponse), _getId(mockDispute));
+    oracle.mock_setCreatedAt(_getId(mockRequest), uint128(block.number));
 
     // Check: revert?
     vm.expectRevert(abi.encodeWithSelector(IOracle.Oracle_NotDisputeOrResolutionModule.selector, proposer));