fix: saving response id too early (#222)

defi-wonderland · Oct 13, 2023 · 73ef904 · 73ef904
1 parent 74236c0
commit 73ef904
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/solidity/contracts/Oracle.sol b/solidity/contracts/Oracle.sol
@@ -195,8 +195,8 @@ contract Oracle is IOracle {
 
     _responseId = keccak256(abi.encodePacked(_proposer, address(this), _requestId, _responseNonce++));
     _participants[_requestId].add(_proposer);
-    _responseIds[_requestId].add(_responseId);
     _responses[_responseId] = _request.responseModule.propose(_requestId, _proposer, _responseData, msg.sender);
+    _responseIds[_requestId].add(_responseId);
 
     if (_responses[_responseId].proposer != _proposer) {
       revert Oracle_CannotTamperParticipant();