refactor: disputeResponse arguments

defi-wonderland · Nov 6, 2023 · e93760e · e93760e
1 parent db7d872
commit e93760e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/solidity/interfaces/modules/dispute/IDisputeModule.sol b/solidity/interfaces/modules/dispute/IDisputeModule.sol
@@ -35,14 +35,13 @@ interface IDisputeModule is IModule {
    * Bonds the tokens of the disputer.
    * @param _responseId The ID of the response being disputed
    * @param _disputer The address of the user who disputed the response
-   * @return _dispute The dispute on the proposed response
    */
   function disputeResponse(
     IOracle.Request calldata _request,
     bytes32 _responseId,
     address _disputer,
     IOracle.Response calldata _response
-  ) external returns (IOracle.Dispute memory _dispute);
+  ) external;
 
   /**
    * @notice Callback executed after a response to a dispute is received by the oracle

diff --git a/solidity/test/mocks/contracts/MockDisputeModule.sol b/solidity/test/mocks/contracts/MockDisputeModule.sol
@@ -13,15 +13,7 @@ contract MockDisputeModule is Module, IMockDisputeModule {
     bytes32 _responseId,
     address _disputer,
     IOracle.Response calldata _response
-  ) external view returns (IOracle.Dispute memory _dispute) {
-    bytes32 _requestId = _getId(_request);
-    _dispute = IOracle.Dispute({
-      disputer: _disputer,
-      proposer: _response.proposer,
-      responseId: _responseId,
-      requestId: _requestId
-    });
-  }
+  ) external {}
 
   function decodeRequestData(bytes calldata _data) public view returns (RequestParameters memory _requestData) {
     _requestData = abi.decode(_data, (RequestParameters));