Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove a TODO comment #16

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: remove a TODO comment #16

merged 1 commit into from
Dec 12, 2023
+0 −2

Conversation

gas1cent
Copy link
Member

The rationale for not implementing multiple disputes per response:

  • the described attack can be mitigated by using certain modules, e.g. pre-dispute modules computing the correct answer on-chain
  • anyone seeing the attack can participate in the dispute or escalate it, making it less attractive for the attacker

@gas1cent gas1cent requested a review from 0xmoebius December 12, 2023 08:33
@gas1cent gas1cent self-assigned this Dec 12, 2023
0xmoebius
0xmoebius approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@0xmoebius 0xmoebius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes complete sense

@0xmoebius 0xmoebius merged commit 505b37f into dev Dec 12, 2023
3 checks passed
@0xmoebius 0xmoebius deleted the feat/remove-todo branch December 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmoebius 0xmoebius 0xmoebius approved these changes

Assignees

@gas1cent gas1cent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gas1cent @0xmoebius