Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: id collision #31

Closed
wants to merge 1 commit into from
Closed

fix: id collision #31

wants to merge 1 commit into from
+214 −147

Conversation

0xJabberwock
Copy link
Member

🤖 Linear

Closes GRT-22

@linear Linear
Copy link

linear bot commented Jul 16, 2024

GRT-22 TOB-WOND-16

@0xJabberwock 0xJabberwock self-assigned this Jul 16, 2024
ashitakah
ashitakah approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ashitakah ashitakah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

0xShaito
0xShaito requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@0xShaito 0xShaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would be much simpler if we just create 2 variables for the other createdAt

  • requestCreatedAt
  • responseCreatedAt
  • disputeCreatedAt
    Like this we generate the domain separation that they are talking about

@0xJabberwock 0xJabberwock deleted the fix/id-collision branch July 18, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xShaito 0xShaito 0xShaito requested changes

@ashitakah ashitakah ashitakah approved these changes

Assignees

@0xJabberwock 0xJabberwock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xJabberwock @ashitakah @0xShaito