feat: access control #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xng
reviewed
Sep 27, 2024
| contract OracleTypehash { | ||
| bytes32 internal constant PROPOSE_TYPEHASH = keccak256('ProposeResponse(Request _request, Response _response)'); | ||
| bytes32 internal constant DISPUTE_TYPEHASH = | ||
| keccak256('DisputeResponse(Request _request, Response _response, Dispute _dispute,)'); |
There was a problem hiding this comment.
Suggested change
| keccak256('DisputeResponse(Request _request, Response _response, Dispute _dispute,)'); | |
| keccak256('DisputeResponse(Request _request, Response _response, Dispute _dispute)'); |
i understand this is a WIP, but this one im pointing because it can be easy to miss
| revert ERC2612ExpiredSignature(_permit.deadline); | ||
| } | ||
| // signature, params (removing the last parameter for the access control), nonce, deadline | ||
| bytes32 structHash = keccak256(abi.encode(_signature, _params, _useNonce(_user), _permit.deadline)); |
There was a problem hiding this comment.
should we add block.chainId for cross-chain, and something like address(this) - this last one not so sure about just want to make sure that this signature is not repeatable in another access control module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPO-XXX