feat: add shared lockbox invariants #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDiscotech
reviewed
Dec 13, 2024
| the on-chain chains list is simplified by assuming that joining the Shared Lockbox is | ||
| equivalent to joining the op-governed dependency set. | ||
| Based on the assumption that a chain joining the op-governed dependency set is an irreversible process, | ||
| it is assume that joining the Shared Lockbox is equivalent to it. |
There was a problem hiding this comment.
Suggested change
| it is assume that joining the Shared Lockbox is equivalent to it. | |
| it is assumed that joining the Shared Lockbox is equivalent to it. |
0xDiscotech
reviewed
Dec 13, 2024
Comment on lines
20
to
21
| Based on the assumption that a chain joining the op-governed dependency set is an irreversible process, | ||
| it is assume that joining the Shared Lockbox is equivalent to it. |
There was a problem hiding this comment.
Is this a business decision or a protocol specification. Should we mention this here 🤔?
In which way is it helpful to explain that when talking about the upgrade process?
0xDiscotech
reviewed
Dec 13, 2024
| @@ -26,19 +29,30 @@ The `OptimismPortal` contract will add the following storage layout and modified | |||
|
|
|||
| ### Integrating `SharedLockbox` | |||
|
|
|||
| The integration with the `SharedLockbox` involves adding extra steps when executing deposit transactions | |||
| The integration with the `SharedLockbox` involves extra steps when executing deposit transactions | |||
There was a problem hiding this comment.
I feel this comment ethereum-optimism#465 (comment) is not 100% addressed like this.
What I understand he's asking is to say sthing like:
The extra steps are:
* Locking ETH on a deposit transactions
* unlocking ETH on finalized withdrawals
0xDiscotech
reviewed
Dec 16, 2024
| The integration with the `SharedLockbox` involves extra steps when executing deposit transactions | ||
| or finalizing withdrawal transactions. | ||
| These steps are locking and unlocking ETH without altering other aspects of the current `OptimismPortal` implementation. | ||
| The integration with the `SharedLockbox` locking ETH when executing deposit transactions and unlocking ETH |
There was a problem hiding this comment.
Suggested change
| The integration with the `SharedLockbox` locking ETH when executing deposit transactions and unlocking ETH | |
| The integration with the `SharedLockbox` involves locking ETH when executing deposit transactions and unlocking ETH |
gotzenx
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.