Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement predicate pushdown for parquet reader #349

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Check expression extraction to use a hashset instead

11763bd
Select commit
Loading
Failed to load commit list.
Open

Implement predicate pushdown for parquet reader #349

Check expression extraction to use a hashset instead
11763bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 1s

74.94% (+0.91%) compared to 896accc

View this Pull Request on Codecov

74.94% (+0.91%) compared to 896accc

Details

Codecov Report

Attention: Patch coverage is 83.74384% with 33 lines in your changes missing coverage. Please review.

Project coverage is 74.94%. Comparing base (896accc) to head (11763bd).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/default/parquet.rs 75.24% 17 Missing and 8 partials ⚠️
kernel/src/engine/arrow_expression.rs 86.00% 3 Missing and 4 partials ⚠️
kernel/src/engine/sync/parquet.rs 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   74.03%   74.94%   +0.91%     
==========================================
  Files          43       43              
  Lines        8137     8542     +405     
  Branches     8137     8542     +405     
==========================================
+ Hits         6024     6402     +378     
- Misses       1733     1738       +5     
- Partials      380      402      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov