Fixed construct the snapshot time #3974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -549,6 +547,8 @@ private SnapshotImpl createSnapshot(LogSegment initSegment, Engine engine) { | |||
| initSegment.version, | |||
| startingFromStr); | |||
|
|
|||
| assertLogFilesBelongToTable(logPath, initSegment.allLogFilesUnsorted()); | |||
There was a problem hiding this comment.
I believe the main goal of the log statement above is to print out how long it took to load the protocol and metadata objects during LogReplay.
So I think the easiest thing to do would be to update the log statement (to not directly mention constructing the snapshot) and move it to right after the LogReplay instance is created. what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #3964 (comment)
How was this patch tested?
Unit tests
Does this PR introduce any user-facing changes?
No