-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: justfile works with Linux now #177
Conversation
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
Signed-off-by: Smuu <[email protected]>
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
justfile (1)
153-164
: Improve Linux package management robustnessThe current implementation has several limitations:
- Only supports Debian/Ubuntu based systems
- Doesn't verify package versions
- Lacks error handling for failed installations
Consider enhancing the Linux package installation:
if [ "$OS" = "Linux" ]; then \ + # Detect package manager + if command -v apt > /dev/null; then \ + PKG_MANAGER="apt" + elif command -v dnf > /dev/null; then \ + PKG_MANAGER="dnf" + else \ + echo "Unsupported Linux distribution. Please install dependencies manually." + exit 1 + fi + for package in build-essential pkg-config libssl-dev libclang-dev clang; do \ - if ! dpkg -s $package > /dev/null 2>&1; then \ + if ! command -v $package > /dev/null 2>&1; then \ echo "Installing $package..."; \ - sudo apt update; \ - sudo apt install $package -y; \ + if [ "$PKG_MANAGER" = "apt" ]; then \ + sudo apt update || { echo "Failed to update package list"; exit 1; } + sudo apt install $package -y || { echo "Failed to install $package"; exit 1; } + elif [ "$PKG_MANAGER" = "dnf" ]; then \ + sudo dnf install $package -y || { echo "Failed to install $package"; exit 1; } + fi else \ echo "$package is already installed."; \ fi; \ done; \ fi
Signed-off-by: Smuu <[email protected]>
Summary by CodeRabbit
New Features
Bug Fixes
cargo prove
command to enhance reliability.