Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Fix crash during program shutdown if initialize_ub is called #2

Open
wants to merge 1 commit into
base: te_move_ub_to_common
Choose a base branch
from

Conversation

anderson101866
Copy link

@anderson101866 anderson101866 commented Jul 19, 2024

  • Given there are some python wrapper object generated by pybind, for C++ API to calls via std::function to python method,
  • These python wrapper object are associated with the struct C

BEFORE: The static C struct is destoryed too late at the program exit. It seems fail to free these wrapper because most python-related object has gone.(like GIL)

AFTER: Associate the C struct with module, so that it can be released at the time module been freed.
Signed-off-by: Anderson Meng [email protected]

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Make UB GEMM can gracefully exit w/o forcely os._exit()
  • Remove os._exit() in examples/tests

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Given there are some python wrapper object generated by pybind, for C++ API to calls via std::function to python method,
- These python wrapper object are associated with the struct C
BEFORE: The static C struct is destoryed too late at the program exit. It seems fail to free these wrapper because most python-related object has gone.(like GIL)
AFTER: Associate the C struct with module, so that it can be released at the time module been freed.
Signed-off-by: Anderson Meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant