-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(assert): improve docs #4876
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4876 +/- ##
==========================================
- Coverage 92.36% 91.95% -0.41%
==========================================
Files 488 487 -1
Lines 41604 38895 -2709
Branches 5405 5388 -17
==========================================
- Hits 38426 35765 -2661
+ Misses 3122 3074 -48
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of not evaluating the example code snippets, in most cases, we could instead remove LOC that throw and keep LOC that don't throw.
* | ||
* Note: This option is experimental and may be removed in the future. | ||
*/ | ||
formatter?: (value: unknown) => string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidenote: see #4891
I think it's good to give explicit example of the case where it throws. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR improves the API docs of
assert
package. Now the@param
@returns
@typeParam
are fully documented. It passes doc-linter check.part of #4600 #3764