-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(yaml): support schema name for 'schema' option #5118
feat(yaml): support schema name for 'schema' option #5118
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
==========================================
- Coverage 92.72% 92.71% -0.01%
==========================================
Files 479 480 +1
Lines 38305 38350 +45
Branches 5394 5400 +6
==========================================
+ Hits 35520 35558 +38
- Misses 2732 2739 +7
Partials 53 53 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like two PRs in one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This PR adds handling of string input for
schema
option forparse
andstringify
. This prepares for #5117(Note: I plan to remove Schema class input for
schema
option at 1.0.0, which prevents exposing internal details of schema implementation as public APIs.)This PR also removes the references to private types
DumperStateOptions
LoaderStateOptions
from public types. This prepares for #3764