Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yaml): support schema name for 'schema' option #5118

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 24, 2024

This PR adds handling of string input for schema option for parse and stringify. This prepares for #5117

(Note: I plan to remove Schema class input for schema option at 1.0.0, which prevents exposing internal details of schema implementation as public APIs.)

This PR also removes the references to private types DumperStateOptions LoaderStateOptions from public types. This prepares for #3764

@github-actions github-actions bot added the yaml label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 74.46809% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.71%. Comparing base (65d4650) to head (c1a5134).
Report is 4 commits behind head on main.

Files Patch % Lines
yaml/schema/mod.ts 62.50% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5118      +/-   ##
==========================================
- Coverage   92.72%   92.71%   -0.01%     
==========================================
  Files         479      480       +1     
  Lines       38305    38350      +45     
  Branches     5394     5400       +6     
==========================================
+ Hits        35520    35558      +38     
- Misses       2732     2739       +7     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like two PRs in one.

yaml/schema/mod.ts Outdated Show resolved Hide resolved
yaml/schema/mod.ts Show resolved Hide resolved
yaml/stringify.ts Outdated Show resolved Hide resolved
yaml/parse.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kt3k kt3k merged commit a4d4e51 into denoland:main Jun 25, 2024
15 checks passed
@kt3k kt3k deleted the feat-yaml-support-schema-name-option-input branch June 25, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants