Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmt): add correct pluralization to fmt/duration when using style: full #6295

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

GriffinJohnston
Copy link
Contributor

@GriffinJohnston GriffinJohnston commented Dec 22, 2024

fix #6293

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the fmt label Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (d625a03) to head (394c87e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6295   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         547      547           
  Lines       41661    41667    +6     
  Branches     6313     6314    +1     
=======================================
+ Hits        40137    40144    +7     
+ Misses       1482     1481    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GriffinJohnston GriffinJohnston changed the title feat(fmt) Added correct pluralization to fmt/duration when using style: full feat(fmt): Added correct pluralization to fmt/duration when using style: full Dec 22, 2024
@GriffinJohnston GriffinJohnston changed the title feat(fmt): Added correct pluralization to fmt/duration when using style: full feat(fmt): Add correct pluralization to fmt/duration when using style: full Dec 22, 2024
@GriffinJohnston GriffinJohnston changed the title feat(fmt): Add correct pluralization to fmt/duration when using style: full feat(fmt): add correct pluralization to fmt/duration when using style: full Dec 22, 2024
@kt3k kt3k changed the title feat(fmt): add correct pluralization to fmt/duration when using style: full fix(fmt): add correct pluralization to fmt/duration when using style: full Dec 23, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Thanks for your PR!

@kt3k kt3k merged commit d02d714 into denoland:main Dec 24, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@std/fmt/duration singularize words when the value === 1
3 participants