-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE/1.2.0] release: v1.2.0 #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: refact memberRealEmoji anti pattern * refactor: refact memberPostReaction anti pattern * refactor: refact memberPostComment anti pattern * refactor: change post module table name * refactor: change entity name in post module * fix: add primary key sql * feature: add transactional annotation * refactor: delete transactional annotation in controller * refactor: validate logic in post controller * refactor: rename service test file * refactor: refact deleteRealEmoji logic
* feature: delete redis file and caching logic * feature: delete redis env value * test: delete redis file in test * chore: delete library related to redis
* feat: implementing pick.. * feat: implement pick feature * feat: add picked members api * feat: implement picked api * feat: implement GET api * feat: check member exists * feat: update api specs * feat: concat sql queries * feat: seperate notification
* refactor: Remove unused api parameter got by parsing token and reformat parameter sequence from MemberController. MemberApi * refactor: Rename and reformat the methods in MemberController * refactor: Rename and reformat the methods in MemberSerivce * refactor: Fix the anti-pattern of MemberController by moving transactional code to MemberService * refactor: Refactor minor code dirty * refactor: Refactor legacy MemberControllerTest by removing unnessary tests and spliting to MemberServiceTest due to anti-pattern refactoring * refactor: Resolve code smell issue, distinguishing AuthenticationFailedException by ErrorCode * feat: Add MemberServiceTests for projections methods
* feature: add type and mission_id column sql * feature: add type and mission_id column to Post Entity * test: fix test due to added column * feat: change type field's type in Post
* hotfix: add Enumerated annotation * hotfix: change char to varchar
* feat: add type field in constructor * feat: add mission post create/read mocking api * test: fix failed test due to added type field * style: add comment * refactor: change type's validate logic in create post * refactor: change type enum value * refactor: rename Enum Type * refactor: change if to swith
…ules_tables.sql (#233)
* feat: Add HomeApi and getFamilyMemberMonthlyRanking spec * feat: Add getFamilyMemberMonthlyRanking api response mocking at HomeController
#235) * feature: add getMissionEligibleStatus and getSurvivalUploadStatus mock api * refactor: rename api name and dto field
* feat: add view based api * docs: update view based api docs * feat: add isMeUploaded * fix: update birthday evaluate logics
* refactor: change exception name * feature: add createMissionPost logic * feature: add searchMissionPost * refactor: add available parameter in createPost and fetchDailyFeeds * refactor: seperate validate logic in mission post
* feat: Add leftUploadCountUntilMissionUnlock, dailyMissionConten and Add debug parameter to control boolean flag * refactor: Integrate HomeAPI to MainViewController and Add getNighttimePage API * fix: Fix wrongly written get mapping url of getNighttimePage * fix: Add the missing GetMapping annotation and fix wrongly written swagger summary
* feature: add getRemainingSurvivalPostCount Api * feature: add getRemainingSurvivalPostCount logic to getDaytimePage Api * test: add getRemainingSurvivalPostCount Repository test * test: add getRemainingSurvivalPostCount Api test
* feature: add getSurvivalUploadStatus API logic * feature: add getMissionAvailableStatus API * test: add getMissionAvailable Repository Test * test: add getMissionAvailable and getSurvivalUploadStatus Api Test * style: change response dto field name * feature: add getMissionAvailableStatus and getSurvivalUploadStatus logic to getDaytimePage * refactor: correct anti code * refactor: add member.deletedAt.isNull condition to isCreatedSurvivalPostByMajority
* refactor: refact calculateRemainingSurvivalPostCountUntilMissuonUnlocked logic * feature: add isActiveMember method and refact code * test: refact test code due to seperated logic * test: add calculateRemainingSurvivalPostCountUntilMissionUnlocked test code
* feat: Add mostRecentSurvivalPostDate in FamilyMemberMonthlyRankingResponse according to requirement * feat: Add isMeMissionUploadedToday field And Rename IsMeUploadedToday as isMeSurvivalUploadedToday from DaytimePageResponse * fix: Fix broken PostApiTest and Add new test for added api
* feat: Divide getCalendar API to getMonthlyCalendar and getDailyCalendar And Impl getDailyCalendar * fix: Add CalendarAPI test code for getDailyCalendar and fix the bug found by test code * refactor: Remove debug system print code * refactor: Extract the code to map post to calendar response as the method * refactor: Extract the code to calculate allFamilyMembersUploaded as the method * fix: Fix the runtime exception during PostType enum mapping
…247) * fix: Add the fields of PostResponse in DailyCalendarResponse * fix: Fix broken CalendarApiTest * fix: Fix broken CalendarApiTest2
* feat: Add getFamilyMembersMonthlySurvivalRanking API in PostController * feat: Add mvc test code for new API(getFamilyMembersMonthlySurvivalRanking) with nested test class * feat: Impl getFamilyMemberMonthlyRanking API at MainViewController * feat: Add mvc test code for new API(getFamilyMemberMonthlyRanking) at MainViewApiTest * fix: Add stream filter to exclude familyMember who didnt upload post at that month from getFamilyMembersMonthlySurvivalRanking API of PostController and Add test code to validate it from PostApiTest and MainViewApiTest * fix: Fix failed broken test code * fix: Fix failed broken test code2 * refactor: Refactor compareTo method of PostRankerDTO for better readability * refactor: Add blank line at that last of MainViewApiTest * refactor: Extract duplicated mapping code from getFamilyMemberMonrhlyRanking method of MainViewController * fix: Fix IndexOutOfBoundsException from getFamilyMemberMonthlyRanking API
…248) * refactor: count family members by family ID logic to count based on yesterday's date * test: fix broken test due to changed logic * style: change api summary * refactor: delete unused method * refactor: refactor isCreatedSurvivalPostByMajority code * test: delete unused test
* chore: Add mission module path in the targets of cicd modification checking * feat: Add DailyMissionRegistrationJob in DailyMissionJob with Spring scheduler and table lock * feat: Impl the methods of MissionService and DailyMissionHistyoryService those api responses was mocked * feat: Add exceptions handling at DailyMissionRegistrationJob * feat: Add DailyMissionHistoryRepositoryTest * feat: Add MissionRepositoryTest for getRandomMissionExcludingIds * feat: Add DailyMissionJobTest for registerDailyMission * feat: Add error handling code for duplicated attempting to create daily mission history and catch exception code * feat: Add tests for newly added error handling and exception catching code * refactor: Refactor method and parameter name according to naming convention * refactor: Delete unnecessary Repository annocation from DailyMissionHistoryRepositoryCustomImpl * fix: Make Nested test class lower case
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
< 여기에 기능 추가 배경 >
➕ 추가/변경된 기능
< 여기에 기능 >
🥺 리뷰어에게 하고싶은 말
< 여기에 하고싶은 말 >