Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-333] feature: 탈퇴한 회원 정보 값으로 "UNKNOWN"이 아닌 null 값을 주도록 수정 #255

Merged
merged 1 commit into from
May 13, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented May 11, 2024

❓ 기능 추가 배경


프론트의 요청으로 탈퇴한 회원 정보 값을 "UNKNOWN"이 아닌 null 값을 주도록 수정했습니다.

➕ 추가/변경된 기능


  • 탈퇴한 회원 정보 값을 "UNKNOWN"이 아닌 null 값을 주도록 수정

🥺 리뷰어에게 하고싶은 말


리뷰부탁드림다

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-333

@Ji-soo708 Ji-soo708 requested review from Kwon770 and CChuYong May 11, 2024 10:11
@Ji-soo708 Ji-soo708 self-assigned this May 11, 2024
@Ji-soo708 Ji-soo708 added the ✨ FEATURE 기능 추가 label May 11, 2024
@Ji-soo708 Ji-soo708 changed the title [OING-333] feature: 탈퇴한 회원 정보 값을 "UNKNOWN"이 아닌 null 값을 주도록 수정 [OING-333] feature: 탈퇴한 회원 정보 값으로 "UNKNOWN"이 아닌 null 값을 주도록 수정 May 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Test Results

 51 files   51 suites   12s ⏱️
141 tests 141 ✅ 0 💤 0 ❌
142 runs  142 ✅ 0 💤 0 ❌

Results for commit c0ccdd0.

Copy link

Code Coverage

File Coverage [22.64%]
MainViewController.java 22.64%
Total Project Coverage 51.98% 🍏

Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지난 오프라인 회의에서 나눈 부분이네요. LGTM!

@Kwon770 Kwon770 merged commit bc1999a into dev May 13, 2024
4 checks passed
@Kwon770 Kwon770 deleted the feature/OING-333 branch May 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants