Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE/1.2.2] Release v1.2.2 #263

Merged
merged 8 commits into from
Jun 21, 2024
Merged

[RELEASE/1.2.2] Release v1.2.2 #263

merged 8 commits into from
Jun 21, 2024

Conversation

CChuYong
Copy link
Member

❓ 기능 추가 배경


1.2.2 릴리즈 PR입니다

➕ 추가/변경된 기능


커밋 참조

🥺 리뷰어에게 하고싶은 말


브랜치 또 고장나서 임시 브랜치 파서 머지하겠슴다. 혹시 추후 작업하시는분들 데브브랜치 날려버리고 메인에서 다시 따주세용

Kwon770 and others added 6 commits June 21, 2024 20:49
* feature: add column to deep_link tbl and family_invite_link tbl

* feature: modify logic for issuing deep links

* feature: add inviter information logic to view-based API

* feature: add family name column to family tbl

* test: add family constructor to familyName field in test

* feature: add countSurvivalPostsByFamilyId method

* feature: add getFamilyMember's info method

* feature: add getFamilyMember's info logic to getFamilyInviteLinkDetails method

* feature: add getFamilyMemberNames logic

* chore: add delete previous data from deep_link and family_invite_link tbl

* test: add MemberRepositoryCustomTest
Copy link

github-actions bot commented Jun 21, 2024

Test Results

 52 files   52 suites   11s ⏱️
144 tests 144 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 55ed365.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 워크플로우에서 컴파일 에러 발생했습니다. 확인 부탁드려요!

@CChuYong
Copy link
Member Author

테스트 워크플로우에서 컴파일 에러 발생했습니다. 확인 부탁드려요!

수정했습니다~!

Copy link

github-actions bot commented Jun 21, 2024

Code Coverage

File Coverage [59.68%]
FamilyResponse.java 100% 🍏
FamilyInviteLinkService.java 100% 🍏
SpringWebConfig.java 100% 🍏
FamilyInviteLink.java 100% 🍏
MemberRepositoryCustomImpl.java 100% 🍏
DeepLinkController.java 92.92% 🍏
MemberService.java 89.67% 🍏
DeepLink.java 80% 🍏
PostRepositoryCustomImpl.java 78.01%
Family.java 74%
FamilyService.java 73.12%
MemberBridgeImpl.java 68.75%
DeepLinkService.java 66.67%
MemberController.java 45.45%
FamilyBridgeImpl.java 37.5%
PostBridgeImpl.java 28.57%
MainViewController.java 22.49%
FamilyInviteViewController.java 19.63%
FamilyController.java 12.5%
UpdateFamilyNameRequest.java 0%
MainPageTopBarResponse.java 0%
FamilyInviteDeepLinkResponse.java 0%
Total Project Coverage 52.6% 🍏

Copy link
Collaborator

@Kwon770 Kwon770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* feature: add familyName field in api

* feature: add UpdateFamilyName API

* fix: fix failed test related to family

* test: add updateFamilyName test code

* refactor: add familyNameEditorId to FamilyResponse
Copy link

Copy link
Member

@Ji-soo708 Ji-soo708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 머지할 때 rebase 머지해주세요~~

@Ji-soo708 Ji-soo708 merged commit acbd1fc into main Jun 21, 2024
3 of 4 checks passed
@Ji-soo708 Ji-soo708 deleted the dev-temp branch June 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants