Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-341] feature: 가족 이름 수정 API 추가 및 조회 API 응답 수정 #264

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Jun 21, 2024

❓ 기능 추가 배경


가족 이름 수정 API를 추가하고 조회 API의 응답에 가족 이름/가족 이름 수정자 필드를 추가했습니다

➕ 추가/변경된 기능


  • 가족 이름 조회 API 추가
  • 가족 조회 API 및 메인 뷰 API 응답에 가족 이름 관련 필드 추가
  • 테스트 코드 추가

🥺 리뷰어에게 하고싶은 말


🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-341

@Ji-soo708 Ji-soo708 added the ✨ FEATURE 기능 추가 label Jun 21, 2024
@Ji-soo708 Ji-soo708 self-assigned this Jun 21, 2024
@Ji-soo708 Ji-soo708 requested a review from CChuYong June 21, 2024 12:56
@github-actions github-actions bot changed the title feature: 가족 이름 수정 API 추가 및 조회 API 응답 수정 [OING-341] feature: 가족 이름 수정 API 추가 및 조회 API 응답 수정 Jun 21, 2024
Copy link

Copy link

Test Results

 52 files   52 suites   11s ⏱️
144 tests 144 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 345fe02.

Copy link

Code Coverage

File Coverage [37.17%]
FamilyResponse.java 100% 🍏
Family.java 74%
FamilyService.java 73.12%
MainViewController.java 22.49%
FamilyController.java 12.5%
UpdateFamilyNameRequest.java 0%
MainPageTopBarResponse.java 0%
Total Project Coverage 52.6% 🍏

@CChuYong CChuYong merged commit 392b32a into dev Jun 21, 2024
4 checks passed
@CChuYong CChuYong deleted the feature/OING-341 branch June 21, 2024 13:13
Ji-soo708 added a commit that referenced this pull request Jun 21, 2024
* feature: add familyName field in api

* feature: add UpdateFamilyName API

* fix: fix failed test related to family

* test: add updateFamilyName test code

* refactor: add familyNameEditorId to FamilyResponse
Ji-soo708 added a commit that referenced this pull request Jun 21, 2024
* feature: add familyName field in api

* feature: add UpdateFamilyName API

* fix: fix failed test related to family

* test: add updateFamilyName test code

* refactor: add familyNameEditorId to FamilyResponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants