Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OING-342] refactor: 딥링크 초대 뷰 API에서 memberId == null 인 경우 추가 #265

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

Ji-soo708
Copy link
Member

@Ji-soo708 Ji-soo708 commented Jun 21, 2024

❓ 기능 추가 배경


딥링크 초대 뷰 API에서 memberId == null 인 경우 isRequesterJoinedFamily가 false가 되도록 추가했습니다

➕ 추가/변경된 기능


  • memberId == null 인 경우 추가

🥺 리뷰어에게 하고싶은 말


memberId == null인지 불린값 주는 응답 필드가 하나 더 필요하다면 알려주세요~

🔗 참조 or 관련된 이슈


https://no5ing.atlassian.net/browse/OING-342

@Ji-soo708 Ji-soo708 added 🔒 HOLD 머지하지 말고 잠시 홀드 ♻️ REFACTORING 리팩토링 우선순위_1 labels Jun 21, 2024
@Ji-soo708 Ji-soo708 requested a review from CChuYong June 21, 2024 15:50
@github-actions github-actions bot changed the title refactor: 딥링크 초대 뷰 API에서 memberId == null 인 경우 추가 [OING-342] refactor: 딥링크 초대 뷰 API에서 memberId == null 인 경우 추가 Jun 21, 2024
Copy link

Copy link

Test Results

 52 files   52 suites   12s ⏱️
144 tests 144 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 5bf1154.

Copy link

Code Coverage

File Coverage [16.82%]
FamilyInviteViewController.java 16.82%
Total Project Coverage 52.59% 🍏

@Ji-soo708 Ji-soo708 removed the 🔒 HOLD 머지하지 말고 잠시 홀드 label Jun 21, 2024
@Ji-soo708 Ji-soo708 self-assigned this Jun 21, 2024
@CChuYong CChuYong merged commit b4b39cb into dev Jun 23, 2024
4 checks passed
@CChuYong CChuYong deleted the feature/OING-342 branch June 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants