[OING-343] refactor: 가족 이름 컬럼 타입 및 검증 로직 수정 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Ji-soo708
commented
Jun 26, 2024
| } | ||
|
|
||
| private void validateFamilyName(String familyName) { | ||
| if ((familyName.codePoints().count() > 10) || familyName.isBlank()) { | ||
| if ((familyName.codePoints().count() > 9) || familyName.isBlank()) { |
There was a problem hiding this comment.
회원 닉네임 로직처럼 사용자가 띄어쓰기 하나만 입력하면 예외던지도록 유지했습니다
Code Coverage
|
Kwon770
requested changes
Jun 26, 2024
| @@ -94,18 +86,15 @@ public void resetScore() { | |||
| } | |||
|
|
|||
| public void updateFamilyName(String familyName, String loginFamilyId) { | |||
There was a problem hiding this comment.
변수명이 잘못된 것 같아요. 기능상 수정 멤버 id가 들어가야하고 Service에서도 loginMemberId를 넣고있네요. 확인부탁드려요!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ 기능 추가 배경
family_name컬럼을 아홉자까지 허용하도록 수정하고familyName을 초기화해도 수정자가 기록되도록 수정했습니다.➕ 추가/변경된 기능
family_name컬럼을 아홉자까지 허용familyName을 초기화해도 수정자가 기록되도록 수정🥺 리뷰어에게 하고싶은 말
확인해주세요~
🔗 참조 or 관련된 이슈
https://no5ing.atlassian.net/browse/OING-343