Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPKG-7: interface adjustments cran review 2 #24

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

dereckmezquita
Copy link
Owner

@dereckmezquita dereckmezquita commented Sep 5, 2024

jira ticket

https://dereckmezquita.atlassian.net/browse/RPKG-7

todo list

  • Version bump

@dereckmezquita dereckmezquita changed the title 7 interface adjustments cran review 2 RPKG-7: interface adjustments cran review 2 Sep 5, 2024
@dereckmezquita dereckmezquita self-assigned this Sep 5, 2024
@dereckmezquita
Copy link
Owner Author

dereckmezquita commented Sep 5, 2024

The validate_property function is for internal use and not to be exported as such I removed the examples.

I have also removed examples from other S3 methods I felt did not need them, $ accessor/setter, == comparator method etc. Usage of these is demonstrated in the rest of the package documentation.

win-builder R check:

* using log directory 'd:/RCompile/CRANguest/R-devel/interface.Rcheck'
* using R Under development (unstable) (2024-09-04 r87094 ucrt)
* using platform: x86_64-w64-mingw32
* R was compiled by
    gcc.exe (GCC) 13.2.0
    GNU Fortran (GCC) 13.2.0
* running under: Windows Server 2022 x64 (build 20348)
* using session charset: UTF-8
* checking for file 'interface/DESCRIPTION' ... OK
* checking extension type ... Package
* this is package 'interface' version '0.1.2'
* package encoding: UTF-8
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Dereck Mezquita <[email protected]>'

New submission

Possibly misspelled words in DESCRIPTION:
  enums (14:97)
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking whether package 'interface' can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking for future file timestamps ... OK
* checking 'build' directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking code files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking installed files from 'inst/doc' ... OK
* checking files in 'vignettes' ... OK
* checking examples ... OK
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ... OK
* checking re-building of vignette outputs ... OK
* checking PDF version of manual ... [22s] OK
* checking HTML version of manual ... OK
* DONE
Status: 1 NOTE

Sincerely,
Dereck

interface_0.1.2.tar.gz

@dereckmezquita dereckmezquita merged commit 61854fa into master Sep 5, 2024
7 checks passed
@dereckmezquita dereckmezquita deleted the RPKG-7-interface-adjustments-CRAN-review-2 branch September 5, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant