-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPKG-7: interface adjustments cran review 2 #24
Merged
dereckmezquita
merged 6 commits into
master
from
RPKG-7-interface-adjustments-CRAN-review-2
Sep 5, 2024
Merged
RPKG-7: interface adjustments cran review 2 #24
dereckmezquita
merged 6 commits into
master
from
RPKG-7-interface-adjustments-CRAN-review-2
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereckmezquita
changed the title
7 interface adjustments cran review 2
RPKG-7: interface adjustments cran review 2
Sep 5, 2024
The validate_property function is for internal use and not to be exported as such I removed the examples. I have also removed examples from other S3 methods I felt did not need them, $ accessor/setter, == comparator method etc. Usage of these is demonstrated in the rest of the package documentation. win-builder R check:
Sincerely, |
dereckmezquita
deleted the
RPKG-7-interface-adjustments-CRAN-review-2
branch
September 5, 2024 04:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira ticket
https://dereckmezquita.atlassian.net/browse/RPKG-7
todo list