Allow override of onInput handler in edit mode #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srubin
changed the title
anjoola
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are fully controlling the draft.js component, and we never want the default onInput to be used. That implies that there's a bug in our decorators that allowed a contenteditable change that did not go through our
onBeforeInputhandler. By allowing us to overrideonInput, we'll be able to (a) recover from the bug by callingeditor.restoreEditorDOM()and also (b) log more details about how this was happening in the first place (e.g., the event'sinputType) so we can eventually fix the bug.