Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for all other ksy files #25

Merged
merged 16 commits into from
Jan 15, 2024
Merged

Add tests for all other ksy files #25

merged 16 commits into from
Jan 15, 2024

Conversation

zonca
Copy link
Contributor

@zonca zonca commented Jan 9, 2024

  • test: improve makefile to compile with patterns
  • test: unit test for fake.ksy
  • test: generate list of libraries dynamically
  • feat: only compile current cpp file
  • test: compare the actual array
  • test index_option.ksy

@zonca zonca mentioned this pull request Jan 10, 2024
Closed
8 tasks
@zonca zonca self-assigned this Jan 10, 2024
zonca added 14 commits January 10, 2024 22:29
@zonca
test: improve makefile to compile with patterns
68ffd1e
@zonca
test: unit test for fake.ksy
39a6d49
@zonca
test: generate list of libraries dynamically
0d2a47d
@zonca
feat: only compile current cpp file
11e3763 
this is needed if we have multiple libraries in the same folder.
see
det-lab#24 (comment)

However when we implement `import`
det-lab#17
we will probably need to revisit again
@zonca
test: compare the actual array
283b3a6
@zonca
test index_option.ksy
2433f53
@zonca
test: testing numpy.ksy
7d0e8c9
@zonca
test: test for pixie4e.ksy
64b1507
@zonca
test: testing records.ksy
9ab51db
@zonca
test: test scdms.ksy
1f43351
@zonca
test: test hello_world
c2bf60a 
Got data file from:
https://github.com/kaitai-io/kaitai_struct_tests
@zonca
test: testing scdms_v8.ksy
2e6d237 
Also modified id in ksy to simplify scripting
Closes det-lab#27
@zonca
test: typo and formatting
0b255c6
@zonca
test: explain why shape is different
43bfbf3
@zonca zonca requested a review from ManasviGoyal January 10, 2024 22:33
ManasviGoyal
ManasviGoyal requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@ManasviGoyal ManasviGoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these with make test and it looks good to me.

Can be make the tests run with pytest run without running the make test first since we need to generate the static library?

Makefile Outdated Show resolved Hide resolved
@zonca zonca requested a review from ManasviGoyal January 15, 2024 17:21
@ManasviGoyal ManasviGoyal merged commit 15287ce into det-lab:main Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManasviGoyal ManasviGoyal ManasviGoyal approved these changes

Assignees

@zonca zonca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonca @ManasviGoyal