-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for fake.ksy #8
Conversation
It would be great if you all (@jpivarski @agoose77, @ianna) can have a look and give your feedback and suggestions on how to move forward with this. |
Just a comment: code copied from dependencies like Awkward's header-only code and Kaitai's C++ runtime shouldn't be version-controlled. The generation process can make copies of these in a build directory, but that's transient. Eventually, the user might even want an option that cleans up (deletes) the working directory when it's done. (Not deleting it would be for debugging purposes.) |
You mean the header files, right? I have added that so that I could test it independently (sincw I have made modifications to the I just added it in a separate branch so that I can get suggestions on how to structure the repository and what should go in the generated code and what not. |
@ManasviGoyal my understanding of this PR is that it shows a hand-written Kaitai → Awkward example that will eventually be generated by kaitai? At this stage I don't exactly know what you'd like for me to review. I'm totally happy to do a review, though! I can imagine that it might feel like there are lots of things to do here. Are you looking for suggestions on how to follow through your plan outlined above? |
Hi, I wanted to get some suggestion on the CMakeLists.txt and how the module will be generated based on the new plan. |
I have added a test for the
fake.ksy
which generates the requiredawkward_array
.These commands reproduce the generated array:
The plan after this is as follows -
awkward
to add the required functions in theLayoutBuilder.h
LayoutBuilder*
) fromAwkwardCompiler.scala
(maybe in a separate file?)CMakeLists.txt
to generate.so
files forkaitai_struct_cpp_runtime
andlib[ksy_name].so
using the source and header files generated by the user after runningkaitai-struct-compiler