Fixes, work from a folder, new README #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Globalization Changed it to work from within a folder (just cleaner)
RavenX8
reviewed
Jan 4, 2021
Comment on lines
+207
to
+208
| const string warpGateModel = Globals.stbroot + "../special/warp_gate01/warp.zms"; | ||
| const string decoSpecialList = Globals.stbroot +"../special/list_deco_special.zsc"; |
There was a problem hiding this comment.
Personally I don't like this as this would resolve to "../3DDATA/stb/../special/warp_gate01/warp.zms" and "../3DDATA/stb/../special/list_deco_special.zsc".
Also this tool is being deprecated in favor for https://github.com/dev-osrose/rose_data_converter
L3nn0x
reviewed
Jan 4, 2021
| internal class Program | ||
| static class Globals | ||
| { | ||
| public const string stbroot = "../3DDATA/stb/"; |
There was a problem hiding this comment.
Can we make this a command line parameter? And default it to "./". This way, people can run it from anywhere and we have some sound default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 'CultureInfo.InvariantCulture' not found by adding using System.Globalization
Fixed few other errors on build
Changed it to work from within a folder (just cleaner)