Using WINUSB_MS_VENDOR_CODE in extra string #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devanlai
requested changes
Dec 3, 2017
There was a problem hiding this comment.
I'm not sure that this would work - I think it would create a temporary character array on the stack that would not be guaranteed to still be valid when the extra string descriptor request comes in.
This could be rectified by making it a static const char array.
|
You are probably right. I did not test it on our device yet (WinUSB still doesn't load correctly; I think I will have to add the extended properties descriptor). |
This might make some future debugging easier.
|
It's static const now. |
devanlai
approved these changes
Dec 5, 2017
|
Thanks, when I get a chance to dig out my windows test machine, I'll verify that it still works. |
|
Seems to be working in our FW |
|
@karel-3d Sorry this took so long to merge - I just finally got around to digging out my Windows 10 test machine. Thanks for the patch! |
|
Ha I don’t work at the job I needed this for anymore. Thanks for replying
though :) and patching
.... now I remember all the USB debugging pain again. >:(
…On Mon, 19 Aug 2019 at 23:53, Devan Lai ***@***.***> wrote:
@karel-3d <https://github.com/karel-3d> Sorry this took so long to merge
- I just finally got around to digging out my Windows 10 test machine.
Thanks for the patch!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAAZT4PVMYVEWP2TESSTZDDQFLFZ7A5CNFSM4EGOIALKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4TTE3I#issuecomment-522662509>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAZT4L4KQZMQNKCE24EGXDQFLFZ7ANCNFSM4EGOIALA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might make some future debugging easier.
I did not test this, but it should work in theory :)