Made dependency on future python 2 only #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KiPart has a dependency on the "future" module. Going through the code I found that the only use of this module is two instances of calling
future.standard_library.install_aliases()
. This function is defined as doing nothing at all on python 3. Thus, the call is only needed on python 2 and it's simple to make it so that it is only called on python 2, making the dependency not needed on python 3.Why is this important? Well, with python 2 having become EOL, distributions are starting to remove python 2, and also the future module (see e.g. https://bugs.gentoo.org/888271). Thus, requiring the module in order to install for python 3 makes packaging difficult (or at least awkward).
Note that uses of
__future__
(with the underscores) are not affected by this at all, since that is a builtin "module" and guaranteed to be available in every Python installation.