-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR : Create a public demonstration repository named cdk-eoapi #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emileten
changed the title
Initial PR
Initial PR : Create a public demonstration repository named cdk-eoapi
Jun 30, 2023
sharkinsspatial
requested changes
Jul 3, 2023
… relationship to be manually established if the data access role is injected, and if not injected move the creation of the trust relationship policy to after the stac ingestor creation to be able to use the exact arn
note to myself. I would like to :
Thoughts @sharkinsspatial ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue developmentseed/eoapi-cdk#47
This PR creates a demonstration of how to use the constructs from https://github.com/developmentseed/cdk-pgstac. It is based on https://github.com/MAAP-Project/maap-cdk-pgstac itself mostly a copy of https://github.com/developmentseed/aws-asdi-pgstac, with the exception of a few bugs removed (back when it was created) and a tiler application that was added.
Most of the work done on top of just copy pasting https://github.com/MAAP-Project/maap-cdk-pgstac is :
@sharkinsspatial I did a basic testing of this PR (synth, deployment, and collection ingest work). I need to do more next week but a first round of reviews would be helpful.
Also, I am not addressing testing and documentation, I am leaving that to next PRs.
Thanks !