Put container, E&A style, etc. #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui-next-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
reviewed
Dec 24, 2024
| <Catalog datasets={transformed} /> | ||
| </Suspense> | ||
| </section> | ||
| <div className='grid-container'> |
There was a problem hiding this comment.
We might need to override the default max width configuration for the grid-container, if we want to match what we have in the Earthdata instance / designs (full width container)?
There was a problem hiding this comment.
I thought the template instance goal is more to provide the structure that any other instance can override those values - like grid-container can be whichever width that people want but the template instance's job is to offer a structure that the defined width will be applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/orgs/nasa-IMPACT/projects/17?pane=issue&itemId=89386654&issue=NASA-IMPACT%7Cveda-ui%7C1282
This PR