Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build support for arm64 #740

Merged
merged 12 commits into from
May 7, 2024

Conversation

Firefishy
Copy link
Contributor

THIS IS FOR COMMENT. Needs some clean-up / refactor work.

What I am changing

  • ARM64 build of the gunicorn container
  • Update GitHub Actions to latest releases
  • Simplify the container tagging by using docker/metadata-action (also fix a case sensitive bug on fork)
  • Add if statements to allow actions to cleanly run if forked
  • Add dependabot to keep GHA updated

How I did it

  • TBC

How you can test it

Related Issues

- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do less than daily? I don't think the actions versions are super important that they deserve a daily check/update

@vincentsarago
Copy link
Member

overall looks good 🙏

@Firefishy
Copy link
Contributor Author

overall looks good 🙏

Cool. I'll refactor and clean it up.

GitHub actions check schedule I'll set to weekly. True update frequency is driven by when upstream have new major releases.

@chris-bateman chris-bateman mentioned this pull request Jan 31, 2024
@vincentsarago
Copy link
Member

@Firefishy can we merge this?

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@vincentsarago
Copy link
Member

rasterio still doesn't provide wheels for Mac OS AMD64 so this PR needs to wait for rasterio/rasterio-wheels#69

@Firefishy
Copy link
Contributor Author

@vincentsarago Sorry, I have been away in South Africa for a month. I am now back and can get this PR into shape.

@vincentsarago vincentsarago marked this pull request as ready for review May 7, 2024 07:30
@vincentsarago
Copy link
Member

I've commented out linux/arm64 because we still need rasterio to provide the wheels.

I'm going to merge this PR because I think it provides nice enhancements to the CI

@vincentsarago vincentsarago merged commit c69a4d5 into developmentseed:main May 7, 2024
10 checks passed
@Firefishy Firefishy deleted the build-for-arm64 branch May 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants