-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: PixiJS (original, original-wordmark, plain, plain-wordmark) #1923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great work! The Devicon.json is very well made.
Only a few small changes need to be made to the SVGs (Padding, overflowing viewbox, and optimization).
Thank you for reviewing and spotting these errors! I have now adjusted the files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original versions could potentially be cleaned up a bit more. It seems like there's a few things that can be removed, but it looks decent already, so there's no need unless you wanna experiment with removing stuff :)
As for the plain versions they look very nice! Just need to unify the path for the plain version and we're good!
Great work so far!
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've optimized the SVGs using this tutorial.
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
https://pixijs.com/branding