-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: webgpu (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Everything looks good, thanks for another great contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Can this PR be merged? It's been 6 months. |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Issues have been resolved and check by other reviewers.
new icon: webgpu (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1936
Link to prove your SVG is correct and up-to-date.
For plain and line SVGs I went with
#005a9c
as it is the most prominent color in the original SVG.Also, webgpu has 2 versions of the wordmark SVG; 1 has the text (Webgpu) underneath the icon and the other has the text on the right side of the icon. I went with the 1st option (Text below the icon) as it's considered the default SVG.