Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: webgpu (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #1941

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1936

Link to prove your SVG is correct and up-to-date.

For plain and line SVGs I went with #005a9c as it is the most prominent color in the original SVG.

Also, webgpu has 2 versions of the wordmark SVG; 1 has the text (Webgpu) underneath the icon and the other has the text on the right side of the icon. I went with the 1st option (Text below the icon) as it's considered the default SVG.

Snailedlt
Snailedlt previously approved these changes Oct 26, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Everything looks good, thanks for another great contribution!

@Snailedlt Snailedlt requested review from a team, ConX, weh and lunatic-fox and removed request for a team October 26, 2023 19:34
@Snailedlt Snailedlt added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Oct 30, 2023
icons/webgpu/webgpu-original-wordmark.svg Outdated Show resolved Hide resolved
icons/webgpu/webgpu-original.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weh weh requested a review from lunatic-fox November 23, 2023 15:17
@nickyvanurk
Copy link

nickyvanurk commented May 8, 2024

Can this PR be merged? It's been 6 months.

@Snailedlt Snailedlt requested review from a team and Snailedlt and removed request for a team May 8, 2024 13:16
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal dismissed lunatic-fox’s stale review November 10, 2024 02:55

Issues have been resolved and check by other reviewers.

@canaleal canaleal merged commit 181c4ad into devicons:develop Nov 10, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: webgpu (original, original-wordmark, plain, plain-wordmark, line, line-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants