-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: appwrite (original, original-wordmark, plain, plain-wordmark) #2196
Conversation
Hey Maintainer Please Review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
The wordmark versions look very good!
The non-wordmark versions are distorted. Please make sure to keep the aspect ratios the same when resizing the icons, so that they don't become distorted.
Thanks @Snailedlt for reviewing this PR Can you tell me how to resolve this issue ? |
@Yashh56 I think the easiest way is downloading the official icons again and making sure that the aspect ratio is maintained when you resize it :) If you're using inkscape you can follow this guide when resizing: #1306 (comment) PS: there's lots of other great guides in that issue as well! |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hey Maintainer Please Review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the changes requested by @Snailedlt are still not resolved.
The original
and plain
version are still squished, and not round anymore.
...also |
And i forgot also that the original and plain should not have that much spacing around the icon.
"aliases": [
{
"base": "plain",
"alias": "original"
}
] |
Refer to guides under this issue as well as the wiki if you're unsure how to fix the issues :) |
how can i squished aspect ratio ? |
I used Resize to resize the aspect ratio |
@Yashh56 If you're using inkscape, make sure you check the box to scale proportionally Here's two different guides to resize to a square. Both can be found as comments in the issue I linked to earlier: |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hey @Snailedlt, Can you review my changes :) |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive optimized the svgs using this tutorial and made sure there were no artifacts in icomoon.
The eps file can be removed as it's not needed anymore and because the original icon is simple enough to be used as the plain icon, the plain svg was removed and replaced with an alias.
All issues have been resolved in the latest commit.
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #2181
Link to prove your SVG is correct and up-to-date.
The color
#fd366e
was selected for the font SVGs as it's the main color in the original logo.