Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: angularjs (plain) #2261

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Finii
Copy link

@Finii Finii commented Sep 5, 2024

[why]
There are two problems with the plain svg:

  • The top of the 'A' consists of a lot of nodes that have a very complex outline, while in reality it should only be one sharp node
  • The 'A' outline is not closed

[how]
Remove superfluous nodes from outline and close it.

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

General location of the problems:

image

Top of the 'A' shape, these are 10 nodes instead of 1 😬

image

Nodes 1 and 2 are not connected, note the missing direction arrow

image

This PR closes NONE

Notes

The non-closed outline breaks direct import into fontforge.

I did not check the other 3 angularjs icons, most likely they are there also.

@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)

[why]
There are two problems with the plain svg:
- The top of the 'A' consists of a lot of nodes that have a very complex
  outline, while in reality it should only be one sharp node
- The 'A' outline is not closed

[how]
Remove superfluous nodes from outline and close it.

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii changed the title angularjs: Fix plain icon update icon: angularjs: Fix plain icon Sep 5, 2024
Snailedlt
Snailedlt previously approved these changes Sep 12, 2024
@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team September 12, 2024 10:48
@Snailedlt Snailedlt changed the base branch from master to develop September 12, 2024 10:49
@Snailedlt Snailedlt dismissed their stale review September 12, 2024 10:49

The base branch was changed.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Finii The changes look good, but they should be merged into the develop branch instead of master. I changed it for you though, so all good now :)

@canaleal canaleal changed the title update icon: angularjs: Fix plain icon update icon: angularjs (plain) Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 291c31f into devicons:develop Oct 3, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants