Implementation of a view layer #844
Conversation
Co-authored-by: RestartFU <[email protected]>
| @@ -232,6 +235,7 @@ func (s *Session) Close() error { | |||
| // close closes the session, which in turn closes the controllable and the connection that the session | |||
| // manages. | |||
| func (s *Session) close() { | |||
| _ = s.viewLayer.Close() | |||
There was a problem hiding this comment.
Why should one viewer leaving close the entire view layer?
There was a problem hiding this comment.
what if multiple sessions has the same view layer
There was a problem hiding this comment.
1 session = 1 view layer
There was a problem hiding this comment.
Then why do view layers store multiple sessions at the moment?
There was a problem hiding this comment.
every player has it's own layer, so that each player can be different, only to a certain player
| } | ||
|
|
||
| // Close closes the view layer. | ||
| func (v *ViewLayer) Close() error { |
There was a problem hiding this comment.
This should also remove the view layer instance from the viewers.
There was a problem hiding this comment.
Like v = nil?
Can you be clearer?
There was a problem hiding this comment.
delete(viewer.viewers, v.e) or something I think, e being the owner of the view layer
|
I feel like I should revise the naming for this... ( |
Co-authored-by: RestartFU