-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test regarding structs with a new Option field #583
Open
randombit
wants to merge
1
commit into
master
Choose a base branch
from
jack/add-opt-serde-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks that adding an Option field to a struct has the expected behavior, where * For an old writer and new reader, the struct deserializes with a field of None * For a new writer and an old reader, the struct deserializes with the value of the Option ignored.
ggreif
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks totally reasonable to me! I just wonder why there was no test for this, as it is one of the cornerstones of Candid... 🧐
Click to see raw report
|
CI failure looks unrelated |
There may well be some other test that covers this, I did look but I could not immediately find it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that adding an Option field to a struct has the expected behavior, where
Overview
This PR just adds a test. Within the crypto team we were not sure if this situation (adding an
Option
to a Candid struct) worked as we expected (CRP-2642). This test is to confirm our understanding. But it also seems like a nice test to have for the future.