-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: next generation of Rust CDK #521
Draft
lwshang
wants to merge
19
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RejectionCode variant SysUnknown * refactor: Call struct * encode_args once * update ic0 with new system API * with_best_effort_response() * doc comments * safe wrapper for msg_deadline() * refactor * add e2e * state machine script using git tag * basic test pass * configs after setting args * call_and_forget * minor improvements * use recent beta dfx which has new system API * clippy * load.bash * update candid-extractor * fmt * group methods in traits * default to 10s timeout:wq * prelude mod * fmt
* ic0: handle 32/64-bits system API * adjust safe bindings * update safety notes * Update call.rs Co-authored-by: Adam Spofford <[email protected]> --------- Co-authored-by: Adam Spofford <[email protected]>
* Add ic-cdk-management-canister crate * move management canister code * flat hierarchy and exclude candid-extractor * exclude root Cargo.lock * rm docs * update workflows * fmt * fix doc * cleanup examples.yml * rm candid-extractor * fix examples.yml * fix cont. * refactor e2e-tests 1:1 mapping of canisters to tests * remove examples
…same name as the function itself (#525) * add a test case to reveal the bug * fix: update/query macro could not handle function arguments with the same name as the function itself * changelog
* duplicate call.rs in crate root * keep only the new call API in root call.rs * CallResult<R> = Result<R, CallError>; * RejectCode & CallPerformErrorCode * remove CleanupExecuted * try add CandidEncodeFailed error type * handle CandidEncodeFailed error properly * copy api/call.rs from main branch and fix for new ic0 * test all Call struct variants and rename ArgDecoderConfig to DecoderConfig * specify CallPerformErrorCode variants
* e2e revails: Call without args fails * fix and e2e call thoroughly * move call internal items * unify wording about cycles * CallWithArg which allow non-tuple arg * docs * with_decoder_config instead of call_with_decoder_config * rename: call -> call_tuple, call_and_forget -> call_oneway * call() allows non-tuple return types
* wip * pocket-ic must be in dev dependencies * conditional compilation for wasm target_family * cleanup * CI wasm64 * fix ci.yml * fix cont. * no fail-fast * rm e2e-tests/src/lib.rs
* deprecated annotations with note * update ic-ledger-types * RejectCode and CallPerformErrorCode have NoError variant * ic-cdk-timers migrate to Call::new * fix deprecation usage in async e2e * fix doctests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK-1853
Description
This PR collects a few big changes:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: