Update Rust project READMEs #1073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berestovskyy
previously approved these changes
Dec 19, 2024
gregorydemay
previously approved these changes
Dec 20, 2024
oggy-dfin
previously approved these changes
Dec 23, 2024
ericswanson-dfinity
previously approved these changes
Dec 27, 2024
fspreiss
reviewed
Jan 3, 2025
jessiemongeon1
commented
Jan 3, 2025
jessiemongeon1
dismissed stale reviews from ericswanson-dfinity, oggy-dfin, and gregorydemay
via
648f33f
jessiemongeon1
commented
Jan 3, 2025
jessiemongeon1
commented
Jan 3, 2025
jessiemongeon1
requested review from
fspreiss,
gregorydemay,
ericswanson-dfinity,
berestovskyy and
oggy-dfin
fspreiss
reviewed
Jan 3, 2025
fspreiss
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for addressing the comments, @jessiemongeon1. I have one final comment.
|
|
||
| ### Deploy and test the canister locally | ||
| ## Step 1: Setup the project environment |
There was a problem hiding this comment.
Maybe group Step 1 and Step 2 (and possibly the Prerequisites) into a Local Deployment parent, similar to how you did the same in the Motoko READMEs in the other PR.
Same for threshold-schnorr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example README files are no longer used on the Dev Docs, so the keyword tags and format can be adjusted to read best on GitHub.
Each README has also been updated to fit latest style guide practices.