Updating actions #63
Updating actions #63
Conversation
dgkf
commented
Oct 11, 2023
dgkf
commented
- Adding testing and linting jobs
.github/workflows/release.yml
Outdated
| - build: x86_64-linux | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: x86_64-unknown-linux-gnu |
There was a problem hiding this comment.
For portability reasons, I recommend using the musl target.
For gnu targets, the binaries built here probably won't work on Debian old stable or Ubuntu 20.04.
| - build: aarch64-linux | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: aarch64-unknown-linux-gnu | ||
| cross: true | ||
|
|
||
| - build: riscv64-linux | ||
| os: ubuntu-latest | ||
| rust: stable | ||
| target: riscv64gc-unknown-linux-gnu | ||
| cross: true |
There was a problem hiding this comment.
To be honest, I don't have a good sense for the advantages of each. What would be the reasons to favor one over the other?
There was a problem hiding this comment.
For riscv64, it seems the toolchain to include rust-std isn't available yet for musl:
https://github.com/dgkf/R/actions/runs/6490904840/job/17627388865?pr=64#step:5:65
There was a problem hiding this comment.
Binaries built with gnu targets are not compatible with environments other than those in which they were built.
See, for example, the following problem with mdBook:
rust-lang/mdBook#1862
rust-lang/mdBook#1954
There was a problem hiding this comment.
I see - okay, then I'll add it where we can. It seems the riscv64 is still going to have to stay on gnu (at least if we want to use the stable toolchain, not sure about nightly/others) but the others can be migrated.
