Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to GHC-9.8.2 (missing: dhall-{lsp-server,nix,nixpkgs}) #2584

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lucasdicioccio
Copy link

Starting something to upgrade to 9.8.2, taking baby-steps absent #2583 .

My goal is to compile with -Werror with 9.8.2 (I run cabal 3.10.3.0 but that shouldn't matter much) then pass tests (without -Werror then with).

  • I've mainly replaced safe head calls to NonEmpty.head . NonEmpty.fromList except in dhall/src/Dhall/Tags.hs (a more human-friendly symbol is welcomed) and dhall-openapi/src/Dhall/Kubernetes/Types.hs (we may expect the parser to occur at a boundary where human-readable errors are paramount)
  • upgrade some package bounds here and there
  • CPP-guard liftA2 imports
  • pass tests
  • same for dhall-{lspt-server,nix,nixpkgs}) (tbc: blocked on hnix)

I'm struggling to find cycles to feel free to take over the pull-request.

@lucasdicioccio lucasdicioccio changed the title Port to GHC-9.8.2 (missing: dhall-{lspt-server,nix,nixpkgs}) Port to GHC-9.8.2 (missing: dhall-{lsp-server,nix,nixpkgs}) Apr 25, 2024
@ysangkok
Copy link
Contributor

I think these look like sensible changes. Given that GHC 9.8.3 will be out in a few days, and the Stackage LTS after that, I think it would be good to merge and release this, so we can keep Dhall in Stackage LTS.

Any reason this is still 'draft' @lucasdicioccio ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants