Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handler for 'documentDidClose' #2613

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add handler for 'documentDidClose' #2613

merged 2 commits into from
Oct 31, 2024

Conversation

ShrykeWindgrace
Copy link
Contributor

Addresses #2612

mmhat
mmhat approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@mmhat mmhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thanks for the contribution @ShrykeWindgrace 👍

dhall-lsp-server/src/Dhall/LSP/Handlers.hs Outdated Show resolved Hide resolved
@mmhat mmhat added the merge me label Oct 31, 2024
@mmhat mmhat merged commit d1fc29b into dhall-lang:main Oct 31, 2024
9 checks passed
@mmhat mmhat removed the merge me label Oct 31, 2024
@mmhat mmhat mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmhat mmhat mmhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShrykeWindgrace @mmhat