Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep dashboard title visible even when user is scrolling [v39] #3156

Draft
wants to merge 6 commits into
base: v39
Choose a base branch
from

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Dec 4, 2024

Implements UX-173

Backport of #3095, though that one is closed as obsolete, since a new dashboard design has been introduced for continuous release supported versions.

Key features
Adjusts design of the TitleBar component to remain visible while scrolling a dashboard.
Adjusts design of TitleBar components to reduce visual noise.
Description
This PR implements changes to the Dashboard view mode to make it easier to understand which dashboard is currently selected. Visual design changes also reduce visual noise.
(This PR supersedes #2210, which had become stale and had an unfixable-to-me bug with the progressive loading.)

TODO

  • Tweak the magic numbers used for control bar rows. It's noticable once you get to 5 rows of chips
  • Margins are missing in edit mode
  • In small screen view, the dashboards bar horizontal scrollbar isn't visible
  • In small screen view, the search button needs better vertical alignment
  • Scrolling in dashboards bar (with a lot of dashboards)

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 4, 2024

🚀 Deployed on https://pr-3156.dashboard.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify December 4, 2024 08:49 Inactive
Copy link

cypress bot commented Dec 4, 2024

dashboards-app    Run #5049

Run Properties:  status check failed Failed #5049  •  git commit ca8bcc0b15: fix: correct calculation of number of rows with new chip dimensions
Project dashboards-app
Branch Review feat/title-bar-improvements-v39
Run status status check failed Failed #5049
Run duration 05m 20s
Commit git commit ca8bcc0b15: fix: correct calculation of number of rows with new chip dimensions
Committer Jen Jones Arnesen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 7
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 51
View all changes introduced in this branch ↗︎

Tests for review

Failed  view_errors.feature • 1 failed test • e2e

View Output Video

Test Artifacts
Errors while in view mode > Edit dashboard containing item that is missing type Screenshots Video
Failed  view_dashboard.feature • 2 failed tests • e2e

View Output Video

Test Artifacts
Viewing dashboards > I expand the control bar Screenshots Video
Viewing dashboards > I expand the control bar when dashboard not found Screenshots Video
Failed  responsive_dashboard.feature • 1 failed test • e2e

View Output Video

Test Artifacts
Small screen dashboard > I view a dashboard Screenshots Video
Failed  dashboard_filter.feature • 3 failed tests • e2e

View Output Video

Test Artifacts
Dashboard filter > I add a Period filter Screenshots Video
Dashboard filter > I add a Organisation unit filter Screenshots Video
Dashboard filter > I add a Facility Type filter Screenshots Video

@jenniferarnesen jenniferarnesen marked this pull request as draft December 4, 2024 11:47
@dhis2-bot dhis2-bot temporarily deployed to netlify December 5, 2024 10:33 Inactive
Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dhis2-bot dhis2-bot temporarily deployed to netlify December 9, 2024 12:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants