-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keep dashboard title visible even when user is scrolling [v39] #3156
Draft
jenniferarnesen
wants to merge
6
commits into
v39
Choose a base branch
from
feat/title-bar-improvements-v39
base: v39
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3156.dashboard.netlify.dhis2.org |
2 tasks
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements UX-173
Backport of #3095, though that one is closed as obsolete, since a new dashboard design has been introduced for continuous release supported versions.
Key features
Adjusts design of the TitleBar component to remain visible while scrolling a dashboard.
Adjusts design of TitleBar components to reduce visual noise.
Description
This PR implements changes to the Dashboard view mode to make it easier to understand which dashboard is currently selected. Visual design changes also reduce visual noise.
(This PR supersedes #2210, which had become stale and had an unfixable-to-me bug with the progressive loading.)
TODO