fix: Fix enrollment queyr to get correct orgUnit [DHIS2-14829] (#19130)

dhis2 · Nov 12, 2024 · 286f75c · 286f75c
1 parent a76769a
commit 286f75c
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/...ain/java/org/hisp/dhis/tracker/export/trackedentity/aggregates/query/EnrollmentQuery.java b/...ain/java/org/hisp/dhis/tracker/export/trackedentity/aggregates/query/EnrollmentQuery.java
@@ -95,7 +95,7 @@ public static String getQuery() {
         + "join program p on en.programid = p.programid "
         + "join trackedentity te on en.trackedentityid = te.trackedentityid "
         + "join trackedentitytype tet on te.trackedentitytypeid = tet.trackedentitytypeid "
-        + "join organisationunit o on te.organisationunitid = o.organisationunitid "
+        + "join organisationunit o on en.organisationunitid = o.organisationunitid "
         + "where en.trackedentityid in (:ids) ";
   }
 

diff --git a/...on/src/test/java/org/hisp/dhis/tracker/export/trackedentity/TrackedEntityServiceTest.java b/...on/src/test/java/org/hisp/dhis/tracker/export/trackedentity/TrackedEntityServiceTest.java
@@ -369,7 +369,7 @@ void setUp() {
     enrollmentA.setFollowup(true);
     manager.save(enrollmentA, false);
 
-    enrollmentB = createEnrollment(programB, trackedEntityA, orgUnitA);
+    enrollmentB = createEnrollment(programB, trackedEntityA, orgUnitB);
     manager.save(enrollmentB);
     trackedEntityA.getEnrollments().add(enrollmentB);
     manager.update(trackedEntityA);
@@ -642,6 +642,42 @@ void shouldReturnTrackedEntityIncludingAllAttributesEnrollmentsEventsRelationshi
                     .collect(Collectors.toSet())));
   }
 
+  @Test
+  void shouldReturnTrackedEntityIncludingAllEnrollments()
+      throws ForbiddenException, NotFoundException, BadRequestException {
+    TrackedEntityOperationParams operationParams =
+        TrackedEntityOperationParams.builder()
+            .organisationUnits(orgUnitA)
+            .orgUnitMode(SELECTED)
+            .trackedEntityType(trackedEntityTypeA)
+            .trackedEntityParams(TrackedEntityParams.TRUE)
+            .build();
+
+    final List<TrackedEntity> trackedEntities =
+        trackedEntityService.getTrackedEntities(operationParams);
+
+    assertContainsOnly(List.of(trackedEntityA.getUid()), uids(trackedEntities));
+    assertContainsOnly(
+        Set.of(enrollmentA.getUid(), enrollmentB.getUid()),
+        uids(trackedEntities.get(0).getEnrollments()));
+    assertEquals(
+        orgUnitA.getUid(),
+        trackedEntities.get(0).getEnrollments().stream()
+            .filter(e -> e.getUid().equals(enrollmentA.getUid()))
+            .findFirst()
+            .get()
+            .getOrganisationUnit()
+            .getUid());
+    assertEquals(
+        orgUnitB.getUid(),
+        trackedEntities.get(0).getEnrollments().stream()
+            .filter(e -> e.getUid().equals(enrollmentB.getUid()))
+            .findFirst()
+            .get()
+            .getOrganisationUnit()
+            .getUid());
+  }
+
   @Test
   void shouldReturnTrackedEntityIncludeSpecificProtectedProgram()
       throws ForbiddenException, NotFoundException, BadRequestException {