WIP - Fix sql gen

dhis2 · Dec 18, 2024 · 5170115 · 5170115
1 parent 3e070ce
commit 5170115
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/...tics/src/main/java/org/hisp/dhis/analytics/event/data/JdbcEnrollmentAnalyticsManager.java b/...tics/src/main/java/org/hisp/dhis/analytics/event/data/JdbcEnrollmentAnalyticsManager.java
@@ -542,12 +542,19 @@ private String addCteFiltersToWhereClause(EventQueryParams params, CTEContext ct
         }
       }
     }
+
     // Handle the row context case
     List<String> rowContextColumns = RowContextUtils.getRowContextWhereClauses(cteContext);
-    if (!StringUtils.isEmpty(whereClause)) {
-      whereClause.append(" AND ");
+    if (rowContextColumns.isEmpty()) {
+      return whereClause.toString();
+    } else {
+      if (whereClause.isEmpty()) {
+        whereClause.append(" where ");
+      } else {
+        whereClause.append(" AND ");
+      }
+      whereClause.append(String.join(" AND ", rowContextColumns));
     }
-    whereClause.append(String.join(" AND ", rowContextColumns));
 
     return whereClause.toString();
   }
@@ -1041,14 +1048,14 @@ private CTEContext getCteDefinitions(EventQueryParams params) {
         String cteSql =
             """
                    -- Generate CTE for program stage items
-                   SELECT DISTINCT ON (enrollment) enrollment, %s as value, %s
+                   SELECT DISTINCT ON (enrollment) enrollment, %s as value%s
                         FROM %s
                         WHERE eventstatus != 'SCHEDULE'
                         AND ps = '%s'
                         ORDER BY enrollment, occurreddate DESC, created DESC"""
                 .formatted(
                     colName,
-                    rowContextAllowedAndNeeded(params, queryItem) ? "true as exists_flag" : "",
+                    rowContextAllowedAndNeeded(params, queryItem) ? " ,true as exists_flag" : "",
                     eventTableName,
                     queryItem.getProgramStage().getUid());